Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 单元格行高拖拽支持多行文本自适应 #2980

Merged
merged 8 commits into from
Nov 20, 2024
Merged

feat: 单元格行高拖拽支持多行文本自适应 #2980

merged 8 commits into from
Nov 20, 2024

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Nov 18, 2024 •
edited
Loading

👀 PR includes

✨ Feature

  • New feature

📝 Description

手动拖拽调整单元格高度时, 根据行高动态计算 maxLines 配置, 支持自适应.

{
  "number": 2367,
  "province": "浙江省",
  "city": "绍兴市\n绍兴市\n绍兴市\n绍兴市\n绍兴市",
  "type": "家具\n家具\n家具",
  "sub_type": "桌子"
}
const s2Options = {
  style: {
    cornerCell: {
      maxLines: Infinity,
    },
    rowCell: {
      maxLines: Infinity,
    },
    colCell: {
      maxLines: Infinity,
    },
  },
}

🖼️ Screenshot

Before After
Kapture 2024-11-18 at 17 00 16 Kapture 2024-11-18 at 16 56 39
Kapture 2024-11-19 at 16 15 15 Kapture 2024-11-19 at 16 11 28

🔗 Related issue link

ref #2963

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel Vercel
Copy link

vercel bot commented Nov 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Nov 20, 2024 3:53am

@github-actions github-actions bot added pr(feature) new feature next 2.0-next 版本的问题 labels Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions GitHub Actions
Copy link
Contributor

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added 🚨 lint failed 静态检查失败 🚨 test failed 单元测试挂了 labels Nov 18, 2024
@github-actions github-actions bot removed the 🚨 lint failed 静态检查失败 label Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

Size Change: +523 B (+0.08%)

Total Size: 617 kB

Filename Size Change
./packages/s2-core/dist/s2-extends.min.js 153 kB +197 B (+0.13%)
./packages/s2-core/dist/s2.min.js 256 kB +319 B (+0.12%)
./packages/s2-react/dist/s2-react.min.js 38.3 kB +2 B (+0.01%)
./packages/s2-vue/dist/s2-vue.min.js 37.4 kB +5 B (+0.01%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2.min.css 388 B
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 125 kB
./packages/s2-react/dist/s2-react.min.css 1.55 kB
./packages/s2-vue/dist/s2-vue.min.css 1.85 kB

compressed-size-action

@lijinke666 lijinke666 changed the title feat: 单元格行高拖拽支持多行文本自适应 [WIP] feat: 单元格行高拖拽支持多行文本自适应 Nov 18, 2024
@github-actions github-actions bot removed the pr(feature) new feature label Nov 18, 2024
@lijinke666 lijinke666 changed the title [WIP] feat: 单元格行高拖拽支持多行文本自适应 feat: 单元格行高拖拽支持多行文本自适应 Nov 19, 2024
@github-actions github-actions bot added the pr(feature) new feature label Nov 19, 2024
@lijinke666 lijinke666 merged commit 535c2aa into next Nov 20, 2024
7 of 9 checks passed
@lijinke666 lijinke666 deleted the feat-text-height-adpative branch November 20, 2024 05:48
@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjgogogo wjgogogo wjgogogo approved these changes

@wuhaiyang wuhaiyang Awaiting requested review from wuhaiyang

Assignees

@lijinke666 lijinke666

Labels
next 2.0-next 版本的问题 pr(feature) new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lijinke666 @wjgogogo